- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Move methods from Map to TyCtxt, part 3. #137350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
        
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | HIR ty lowering was modified cc @fmease Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in match checking cc @Nadrieril Some changes occurred in compiler/rustc_passes/src/check_attr.rs | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
1445974    to
    8f926cf      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
Continuing the work from rust-lang#137162. Every method gains a `hir_` prefix.
8f926cf    to
    806be25      
    Compare
  
    | Phew, that's a lot of trivial changes! r=me when PR CI is green. | 
| Thanks for the fast review. @bors r=Zalathar | 
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Feb 21, 2025 
    
    
      
  
    
      
    
  
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items) - rust-lang#136148 (Optionally add type names to `TypeId`s.) - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`) - rust-lang#137336 (Stabilise `os_str_display`) - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.) - rust-lang#137353 (Implement `read_buf` for WASI stdin) - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838) - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy) - rust-lang#137374 (Stacker now handles miri using a noop impl itself) - rust-lang#137392 (remove few unused fields) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Feb 21, 2025 
    
    
      
  
    
      
    
  
Rollup merge of rust-lang#137350 - nnethercote:remove-Map-3, r=Zalathar Move methods from Map to TyCtxt, part 3. A follow-up to rust-lang#137162. r? `@Zalathar`
    
  nnethercote 
      added a commit
        to nnethercote/rust
      that referenced
      this pull request
    
      Feb 24, 2025 
    
    
      
  
    
      
    
  
Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.
    
  nnethercote 
      added a commit
        to nnethercote/rust
      that referenced
      this pull request
    
      Feb 25, 2025 
    
    
      
  
    
      
    
  
Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.
    
  flip1995 
      pushed a commit
        to flip1995/rust
      that referenced
      this pull request
    
      Feb 27, 2025 
    
    
      
  
    
      
    
  
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items) - rust-lang#136148 (Optionally add type names to `TypeId`s.) - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`) - rust-lang#137336 (Stabilise `os_str_display`) - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.) - rust-lang#137353 (Implement `read_buf` for WASI stdin) - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838) - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy) - rust-lang#137374 (Stacker now handles miri using a noop impl itself) - rust-lang#137392 (remove few unused fields) r? `@ghost` `@rustbot` modify labels: rollup
    
  nnethercote 
      added a commit
        to nnethercote/rust
      that referenced
      this pull request
    
      Mar 4, 2025 
    
    
      
  
    
      
    
  
Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.
    
  nnethercote 
      added a commit
        to nnethercote/rust
      that referenced
      this pull request
    
      Mar 4, 2025 
    
    
      
  
    
      
    
  
Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.
    
  jieyouxu 
      added a commit
        to jieyouxu/rust
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? `@Zalathar`
    
  github-actions bot
      pushed a commit
        to tautschnig/verify-rust-std
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items) - rust-lang#136148 (Optionally add type names to `TypeId`s.) - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`) - rust-lang#137336 (Stabilise `os_str_display`) - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.) - rust-lang#137353 (Implement `read_buf` for WASI stdin) - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838) - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy) - rust-lang#137374 (Stacker now handles miri using a noop impl itself) - rust-lang#137392 (remove few unused fields) r? `@ghost` `@rustbot` modify labels: rollup
    
  github-actions bot
      pushed a commit
        to tautschnig/verify-rust-std
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#132876 (rustdoc book: acknowledge --document-hidden-items) - rust-lang#136148 (Optionally add type names to `TypeId`s.) - rust-lang#136609 (libcore/net: `IpAddr::as_octets()`) - rust-lang#137336 (Stabilise `os_str_display`) - rust-lang#137350 (Move methods from Map to TyCtxt, part 3.) - rust-lang#137353 (Implement `read_buf` for WASI stdin) - rust-lang#137361 (Refactor `OperandRef::extract_field` to prep for MCP838) - rust-lang#137367 (Do not exempt nonexistent platforms from platform policy) - rust-lang#137374 (Stacker now handles miri using a noop impl itself) - rust-lang#137392 (remove few unused fields) r? `@ghost` `@rustbot` modify labels: rollup
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? ``@Zalathar``
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? `@Zalathar`
    
  nnethercote 
      added a commit
        to nnethercote/rust
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.
    
  jieyouxu 
      added a commit
        to jieyouxu/rust
      that referenced
      this pull request
    
      Mar 12, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? `@Zalathar`
    
  jieyouxu 
      added a commit
        to jieyouxu/rust
      that referenced
      this pull request
    
      Mar 12, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? ``@Zalathar``
    
  Manishearth 
      added a commit
        to Manishearth/rust
      that referenced
      this pull request
    
      Mar 12, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang#137350. r? ```@Zalathar```
    
  jieyouxu 
      pushed a commit
        to jieyouxu/rustc-dev-guide
      that referenced
      this pull request
    
      Mar 13, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang/rust#137350. r? ```@Zalathar```
    
  github-actions bot
      pushed a commit
        to rust-lang/miri
      that referenced
      this pull request
    
      Mar 14, 2025 
    
    
      
  
    
      
    
  
Move methods from Map to TyCtxt, part 4. A follow-up to rust-lang/rust#137350. r? ```@Zalathar```
    
  flip1995 
      pushed a commit
        to flip1995/rust
      that referenced
      this pull request
    
      Mar 20, 2025 
    
    
      
  
    
      
    
  
Continuing the work from rust-lang#137350. Removes the unused methods: `expect_variant`, `expect_field`, `expect_foreign_item`. Every method gains a `hir_` prefix.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-attributes
  Area: Attributes (`#[…]`, `#![…]`) 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  
    T-rustdoc
  Relevant to the rustdoc team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
A follow-up to #137162.
r? @Zalathar